Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #10038: Add support for KubeAPIServer --request-timeout flag #10040

Conversation

hakman
Copy link
Member

@hakman hakman commented Oct 11, 2020

Cherry pick of #10038 on release-1.18.

#10038: Add support for KubeAPIServer --request-timeout flag

For details on the cherry pick process, see the cherry pick requests page.

In this commit, we initialize the support of --request-timeout flag on
the configuration of KubeAPIServer so as to enable users for setting
timeout duration value for all kinds of handlers.

Signed-off-by: dntosas <ntosas@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Oct 11, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 11, 2020
@k8s-ci-robot k8s-ci-robot added area/api approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 11, 2020
@hakman
Copy link
Member Author

hakman commented Oct 11, 2020

@dntosas this should make things faster :).

@dntosas
Copy link
Contributor

dntosas commented Oct 11, 2020

@dntosas this should make things faster :).

thanx a lot @hakman! i was afk and now i saw your comment on the other PR :)

@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6318f5d into kubernetes:release-1.18 Oct 11, 2020
@hakman hakman deleted the automated-cherry-pick-of-#10038-upstream-release-1.18 branch October 17, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants