Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move NLB's VPC CIDR security group rule logic into model #10161

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Move NLB's VPC CIDR security group rule logic into model #10161

merged 1 commit into from
Nov 3, 2020

Commits on Nov 3, 2020

  1. Move NLB's VPC CIDR security group rule logic into model 

    This way the security group rule task doesn't need to be aware of VPCs, since we know the VPC CIDR ahead of time via cluster spec.

This also fixes the terraform and cloudformation rendering of this rule (see the added cidr block in the integration test outputs)

These rules are for NLB's health checks. The AWS docs recommend allowing access from the entire VPC CIDRs
Also add rules for additionalNetworkCIDRs, supporting VPCs with multiple CIDR blocks.
    @rifelpet
    rifelpet committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    f082848 View commit details
    Browse the repository at this point in the history