Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-arch image pushing #10270

Merged
merged 1 commit into from Nov 19, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Nov 19, 2020

Manifest pushing seems broken because of cross-repo image pushing. Switching to pushing to same repo tags with arch suffix should get it fixed, same as we do with etcd-manager.

https://storage.googleapis.com/kubernetes-jenkins/logs/kops-postsubmit-push-to-staging/1329154456519970816/build-log.txt

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman
Copy link
Member Author

hakman commented Nov 19, 2020

/cc @olemarkus @rifelpet

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 19, 2020
@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit 374f4bb into kubernetes:master Nov 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 19, 2020
k8s-ci-robot added a commit that referenced this pull request Nov 19, 2020
…10270-upstream-release-1.19

Automated cherry pick of #10265: Push multi-arch images #10270: Fix multi-arch image pushing
@hakman hakman deleted the fix-multi-arch-push branch November 22, 2020 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kops-controller cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants