Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config options for container runtime package URL and Hash #10473

Merged

Conversation

hakman
Copy link
Member

@hakman hakman commented Dec 19, 2020

A more recent implementation of #6956 and #7974.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/api approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 19, 2020
@hakman hakman force-pushed the custom-container-runtime-package branch from 786459a to 9fb0a97 Compare December 19, 2020 17:55
@hakman
Copy link
Member Author

hakman commented Dec 19, 2020

FYI @michaelajr.

@hakman hakman force-pushed the custom-container-runtime-package branch 2 times, most recently from 6f38bf8 to 52e1ad2 Compare December 21, 2020 11:34
@hakman hakman force-pushed the custom-container-runtime-package branch 3 times, most recently from abe951b to 4e804c9 Compare December 22, 2020 08:31
@hakman
Copy link
Member Author

hakman commented Dec 23, 2020

/test all

@hakman hakman force-pushed the custom-container-runtime-package branch 2 times, most recently from 8bc3ce5 to b856d90 Compare December 23, 2020 11:18
@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2020
@hakman
Copy link
Member Author

hakman commented Dec 23, 2020

/test pull-kops-e2e-k8s-containerd

k8s-ci-robot added a commit that referenced this pull request Dec 23, 2020
…-upstream-release-1.19

Automated cherry pick of #10473: Add config options for container runtime package URL and Hash
@k8s-ci-robot k8s-ci-robot merged commit b5afd1d into kubernetes:master Dec 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 23, 2020
@hakman hakman deleted the custom-container-runtime-package branch January 6, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants