WIP: Install docker from static binary archive

[austinmoore-]

Add the functionality to install docker from a static binary archive.

This solution was discussed in the November 8th office hours. This is a solution to a problem that I've run into where I cannot download docker binaries from download.docker.com and must use an internal mirror. The initial fix I had for this problem was in #6956, but that solution doesn't handle heterogenous clusters.

NOTE: This assumes that all instance groups in your cluster are running with the same CPU architecture.

[k8s-ci-robot]

Hi @austinmoore-. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: austinmoore-
To complete the pull request process, please assign geojaz
You can assign the PR to them by writing /assign @geojaz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[austinmoore-]

I've marked this as a WIP, even though I think the work is pretty much finished. I just want to continue trying it out for a little while longer, and get community input.

[austinmoore-]

/assign @justinsb

Assigning to Justin, at least for the initial review since he is aware of this from the office hours. Feel free to assign it to someone else.

[mikesplain]

Awesome! Thanks for diving into this! I'll approve the PR for testing for now while we await reviews.

/ok-to-test

[k8s-ci-robot]

@austinmoore-: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[michaelajr]

Hi. Where does this stand? We can longer cherry pick #6956 (for several reasons that I will not go into here). We need a way to specify the docker download location.

[michaelajr]

/remove-lifecycle rotten

[michaelajr]

@austinmoore- Any chance you resolve conflicts?

[austinmoore-]

@michaelajr Yeah I can resolve the conflicts and get this shored up soon.

I think the end result is to refactor docker.go. As @justinsb mentioned in on of the bi-weekly meetings, docker.go has kinda outgrown its needs. I'll come up with something and propose it to the maintainers and get us an end state that I can just then implement.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[k8s-ci-robot]

@austinmoore-: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-kops-verify-generated	877880a	link	/test pull-kops-verify-generated
pull-kops-bazel-build	877880a	link	/test pull-kops-bazel-build
pull-kops-verify-govet	877880a	link	/test pull-kops-verify-govet
pull-kops-bazel-test	877880a	link	/test pull-kops-bazel-test
pull-kops-e2e-kubernetes-aws	877880a	link	/test pull-kops-e2e-kubernetes-aws
pull-kops-verify-staticcheck	877880a	link	/test pull-kops-verify-staticcheck
pull-kops-e2e-k8s-containerd	877880a	link	/test pull-kops-e2e-k8s-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[johngmyers]

I would much rather the docker/containerd download go through asset remapping like all the other downloads. I'm thinking we move the packageVersion information for the PlainBinary versions to cloudup so they can be remapped and then passed through NodeupConfig, leaving the older rpm/deb versions in nodeup until such time as we drop support for them.

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.