Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Install docker from static binary archive #7974

Open
wants to merge 8 commits into
base: master
from

Conversation

@austinmoore-
Copy link
Contributor

austinmoore- commented Nov 20, 2019

Add the functionality to install docker from a static binary archive.

This solution was discussed in the November 8th office hours. This is a solution to a problem that I've run into where I cannot download docker binaries from download.docker.com and must use an internal mirror. The initial fix I had for this problem was in #6956, but that solution doesn't handle heterogenous clusters.

NOTE: This assumes that all instance groups in your cluster are running with the same CPU architecture.

# Conflicts:
#	cmd/kops/integration_test.go
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 20, 2019

Hi @austinmoore-. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 20, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: austinmoore-
To complete the pull request process, please assign geojaz
You can assign the PR to them by writing /assign @geojaz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@austinmoore- austinmoore- changed the title Install docker from static binary archive WIP: Install docker from static binary archive Nov 20, 2019
@austinmoore-

This comment has been minimized.

Copy link
Contributor Author

austinmoore- commented Nov 20, 2019

I've marked this as a WIP, even though I think the work is pretty much finished. I just want to continue trying it out for a little while longer, and get community input.

@austinmoore-

This comment has been minimized.

Copy link
Contributor Author

austinmoore- commented Nov 20, 2019

/assign @justinsb

Assigning to Justin, at least for the initial review since he is aware of this from the office hours. Feel free to assign it to someone else.

@mikesplain

This comment has been minimized.

Copy link
Member

mikesplain commented Nov 20, 2019

Awesome! Thanks for diving into this! I'll approve the PR for testing for now while we await reviews.

/ok-to-test

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 22, 2019

@austinmoore-: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kops-verify-generated 877880a link /test pull-kops-verify-generated
pull-kops-bazel-build 877880a link /test pull-kops-bazel-build
pull-kops-verify-govet 877880a link /test pull-kops-verify-govet
pull-kops-bazel-test 877880a link /test pull-kops-bazel-test
pull-kops-e2e-kubernetes-aws 877880a link /test pull-kops-e2e-kubernetes-aws
pull-kops-verify-staticcheck 877880a link /test pull-kops-verify-staticcheck

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Dec 22, 2019

@austinmoore-: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.