Install dbus if needed for protokube with containerd #10583
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/nodeup
approved
|
Marking as WIP because I'm not entirely sure when we actually need the dbus mount; it might suffice only to use it when we're not using etcd-manager (and we should probably try so that we can remove the dbus dependency) |
nodeup/pkg/model/protokube.go
Outdated
| @@ -101,6 +101,15 @@ func (t *ProtokubeBuilder) Build(c *fi.ModelBuilderContext) error { | |||
| } | |||
| c.AddTask(service) | |||
|
|
|||
| if t.Cluster.Spec.ContainerRuntime == "containerd" { | |||
There was a problem hiding this comment.
This is not related just to containerd, but in general, because it is needed by Systemd to work properly (at least that is how I remember from testing a while back).
There was a problem hiding this comment.
At most, the condition should be to install dbus if distro is Kopeio.
|
note that this should fix the legacy etcd prow job as well: https://testgrid.k8s.io/kops-misc#kops-aws-legacy-etcd |
hakman
force-pushed
the
install_dbus
branch
3 times, most recently
from
232df08
to
b750eb1
Compare
hakman
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
k8s-ci-robot
added
the
lgtm
…-upstream-release-1.19 Automated cherry pick of #10583: Install dbus if needed for protokube with kope.io
Issue #10122