Remove taints from spotinst ocean terraform resource #10674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field isn't being set anywhere and is causing problems with the terraform HCL2 serialization. If we do end up setting it we can redefine the struct type ourselves with the necessary field tags.
k8s-ci-robot
added
cncf-cla: yes
liranp
approved these changes
Jan 28, 2021
There was a problem hiding this comment.
Thanks for the quick fix, @rifelpet. I'll raise another PR to fix the Launch Spec resource as well.
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liranp, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
alejandroandreu
pushed a commit
to alejandroandreu/kops
that referenced
this pull request
Jan 29, 2021
Fixes kubernetes#10671 As mentioned by @liranp on kubernetes#10674, this was still necessary for Kops to be able to spit Terraform code when using the Spotinst integration.
|
@liranp any chance you can get the LaunchSpec fixed for this issue soon? We're considering it for a 1.19.1 release. |
k8s-ci-robot
added a commit
that referenced
this pull request
Feb 6, 2021
…74-origin-release-1.19 Automated cherry pick of #10674: Remove taints from spotinst ocean terraform resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field isn't being set anywhere and is causing problems with the terraform HCL2 serialization.
If we do end up setting it we can redefine the struct type ourselves with the necessary field tags.
Fixes #10671
/cc @liranp