Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotinst: Replace corev1.Taint to fix HCL2 serialization #10819

Merged
merged 1 commit into from
Feb 14, 2021

Conversation

liranp
Copy link
Contributor

@liranp liranp commented Feb 14, 2021

This PR fixes Terraform output of Ocean resources (refs: #10671, #10674, #10679, #10806).

/cc @rifelpet
/cc @hakman
/cc @alejandroandreu

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/provider/spotinst Issues or PRs related to spotinst provider labels Feb 14, 2021
@hakman
Copy link
Member

hakman commented Feb 14, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2021
@hakman
Copy link
Member

hakman commented Feb 14, 2021

Thanks @liranp.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, liranp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8e9f91b into kubernetes:master Feb 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Feb 14, 2021
k8s-ci-robot added a commit that referenced this pull request Feb 14, 2021
…-upstream-release-1.20

Automated cherry pick of #10819: fix(spot/ocean): replace corev1.Taint to fix hcl2
@liranp liranp deleted the fix-spot-tf branch February 24, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/spotinst Issues or PRs related to spotinst provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants