Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fix ServiceAccountVolume proposed configuration for Istio #10712

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Docs: Fix ServiceAccountVolume proposed configuration for Istio #10712

merged 1 commit into from
Feb 2, 2021

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented Feb 2, 2021 •
edited
Loading

Seems that after merging #9534 there is no need to specify paths for key-files for service Account Token Volume Projection.

Instead, the current configuration proposed in docs is making Istio unable to verify JWT token with errors.

2021-02-01T22:05:23.240319Z     error   ads     Failed to authenticate client from x.x.x.x
Authenticator ClientCertAuthenticator: no verified chain is found
; Authenticator KubeJWTAuthenticator: failed to validate the JWT from cluster Kubernetes: the service account authentication returns an error: [invalid bearer token, square/go-jose: error in cryptographic primitive, unknown]

In this commit, we remove the paths, letting Kops handles the default ones that are working as expected.

@dntosas
Docs: Fix ServiceAccountVolume proposed configuration for Istio
3a5d6ff 
Seems that after merging kubernetes#9534
there is no need to specify paths for key-files for service Account
Token Volume Projection. Instead, current configuration proposed is
making Istio unable to verify JWT token with errors.

In this commit, we remove the paths, letting Kops handles the default
ones that are working as expected.

Signed-off-by: dntosas <ntosas@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @dntosas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 2, 2021
@rifelpet
Copy link
Member

rifelpet commented Feb 2, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 2, 2021
@dntosas dntosas mentioned this pull request Feb 2, 2021
Merged
@olemarkus
Copy link
Member

/lgtm
/approve

Thanks for catching!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dntosas, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit b7f1f69 into kubernetes:master Feb 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Feb 2, 2021
@dntosas dntosas deleted the fix-docs-for-service-account-volume branch February 2, 2021 20:18
This was referenced Apr 19, 2021
Closed
Merged
@agilgur5 agilgur5 mentioned this pull request Aug 19, 2021
Closed
@dntosas dntosas mentioned this pull request Oct 7, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dntosas @k8s-ci-robot @rifelpet @olemarkus