-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kops Docs: Fix ServiceAccountVolume proposed configuration #8893
Kops Docs: Fix ServiceAccountVolume proposed configuration #8893
Conversation
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @dntosas. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1fd434c
to
726c3f8
Compare
@@ -16,27 +16,24 @@ If you wish to run Istio [Secret Discovery Service](https://www.envoyproxy.io/do | |||
$ kops edit cluster $YOURCLUSTER | |||
{{< /text >}} | |||
|
|||
1. Add the following in the configuration file: | |||
2. Add the following in the configuration file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving these items as 1. lets them be renumbered automatically as other items are added in the middle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanx for catching this ^^ pushed changes
/ok-to-test |
Seems that after merging kubernetes/kops#9534 there is no need to specify paths for key-files for service Account Token Volume Projection. Instead, current configuration proposed is making Istio unable to verify JWT token with errors. In this commit, we remove the paths, letting Kops handles the default ones that are working as expected. Signed-off-by: dntosas <ntosas@gmail.com>
726c3f8
to
33ecc88
Compare
/retest |
@dntosas: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Seems that after merging kubernetes/kops#9534 there is no need to specify paths for key-files for service Account Token Volume Projection.
Instead, current configuration proposed is making Istio unable to verify JWT token with errors.
In this commit, we remove the paths, letting Kops handles the default ones that are working as expected.
Relevant PR also opened at Kops repo kubernetes/kops#10712
[x] Configuration Infrastructure
[x] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure