Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kops Docs: Fix ServiceAccountVolume proposed configuration #8893

Merged

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented Feb 2, 2021

Seems that after merging kubernetes/kops#9534 there is no need to specify paths for key-files for service Account Token Volume Projection.

Instead, current configuration proposed is making Istio unable to verify JWT token with errors.

2021-02-01T22:05:23.240319Z     error   ads     Failed to authenticate client from x.x.x.x
Authenticator ClientCertAuthenticator: no verified chain is found
; Authenticator KubeJWTAuthenticator: failed to validate the JWT from cluster Kubernetes: the service account authentication returns an error: [invalid bearer token, square/go-jose: error in cryptographic primitive, unknown]

In this commit, we remove the paths, letting Kops handles the default ones that are working as expected.

Relevant PR also opened at Kops repo kubernetes/kops#10712

[x] Configuration Infrastructure
[x] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure

@dntosas dntosas requested a review from a team as a code owner February 2, 2021 16:57
@istio-policy-bot
Copy link

😊 Welcome! This is either your first contribution to the Istio documentation repo, or
it's been awhile since you've been here. A few things you should know:

  • You can learn about how we write and maintain documentation, about our style guidelines,
    and about all the available web site features by visiting Contributing to the Docs.

  • In the next few minutes, an automatic preview of your change will be
    built as a full copy of the istio.io website. You can find this preview by clicking on
    the Details link next to the deploy/netlify entry in the Status section of this
    page.

  • We care about quality, so we've put in place a number of checks to ensure our documentation
    is top notch. We do spell checking, we sanitize the markdown, we ensure all hyperlinks point
    to valid location, and more. If your PR doesn't pass one of these checks, you'll see a red X in the
    status section of the page. Click on the Details link to get a list of the problems with your PR.
    Fix those problems and push an update to your PR. This will automatically rerun the tests and
    hopefully this time everything will be perfect.

  • Once your changes are accepted and merged into the repository, they will initially show up
    on https://preliminary.istio.io. The changes will be published to https://istio.io
    the next time we do a major release (which typically happens every 3 months or so).

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 2, 2021
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Feb 2, 2021
@istio-testing
Copy link
Contributor

Hi @dntosas. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dntosas dntosas force-pushed the fix-docs-for-kops-service-account-volume branch from 1fd434c to 726c3f8 Compare February 2, 2021 17:07
ericvn
ericvn previously requested changes Feb 2, 2021
@@ -16,27 +16,24 @@ If you wish to run Istio [Secret Discovery Service](https://www.envoyproxy.io/do
$ kops edit cluster $YOURCLUSTER
{{< /text >}}

1. Add the following in the configuration file:
2. Add the following in the configuration file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving these items as 1. lets them be renumbered automatically as other items are added in the middle.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanx for catching this ^^ pushed changes

@ericvn
Copy link
Contributor

ericvn commented Feb 2, 2021

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Feb 2, 2021
Seems that after merging kubernetes/kops#9534
there is no need to specify paths for key-files for service Account
Token Volume Projection.

Instead, current configuration proposed is making Istio unable to verify
JWT token with errors. In this commit, we remove the paths, letting Kops
handles the default ones that are working as expected.

Signed-off-by: dntosas <ntosas@gmail.com>
@dntosas dntosas force-pushed the fix-docs-for-kops-service-account-volume branch from 726c3f8 to 33ecc88 Compare February 2, 2021 19:48
@dntosas
Copy link
Contributor Author

dntosas commented Feb 2, 2021

/retest

@ericvn ericvn dismissed their stale review February 2, 2021 19:59

Changes made

@istio-testing
Copy link
Contributor

@dntosas: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
doc.test.profile_none_istio.io 33ecc88 link /test doc.test.profile_none_istio.io
doc.test.profile_default_istio.io 33ecc88 link /test doc.test.profile_default_istio.io

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@istio-testing istio-testing merged commit d65c363 into istio:master Feb 2, 2021
@dntosas dntosas deleted the fix-docs-for-kops-service-account-volume branch February 2, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/environments area/user experience cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants