Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve cloudLabel validation #10910

Merged
merged 1 commit into from
Feb 27, 2021

Conversation

olemarkus
Copy link
Member

We were too strict on some labels that blocked common use cases such as CAS. At the same time we allowed IG-level cloudLabels that could result in broken clusters.

Fixes #10862

We were too strict on some labels that blocked common use cases such as CAS. At the same time we allowed IG-level cloudLabels that could result in broken clusters
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2021
@hakman
Copy link
Member

hakman commented Feb 27, 2021

Would be nice to cherry-pick this to 1.19 too.

@k8s-ci-robot k8s-ci-robot merged commit a043925 into kubernetes:master Feb 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 27, 2021
@olemarkus olemarkus deleted the fix-cloudlabel-validation branch February 27, 2021 21:02
k8s-ci-robot added a commit that referenced this pull request Feb 28, 2021
…910-origin-release-1.20

Automated cherry pick of #10910: Further improve cloudLabel validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal Pod Autoscaler Label clash
3 participants