Remove instance-selector label #11048
Conversation
k8s-ci-robot
added
cncf-cla: yes
| @@ -501,10 +501,10 @@ func decorateWithMixedInstancesPolicy(instanceGroup *kops.InstanceGroup, usageCl | |||
| } | |||
|
|
|||
| generatedWithLabelKey := "kops.k8s.io/instance-selector" | |||
There was a problem hiding this comment.
@olemarkus what do you think, should we remove this completely?
There was a problem hiding this comment.
My intention for this label was to show infrastructure operators within the AWS console that the group was generated with instance selector. I thought it would be more helpful as a real tag rather than a node label for that reason.
There was a problem hiding this comment.
i understand @bwagner5 . Curious to know why that info will be useful for operators?
There was a problem hiding this comment.
@bwagner5 would it cause any issues if this label was removed?
There was a problem hiding this comment.
I don't think so, I guess it's not too useful. I was thinking it would be nice to know which ones were generated with instance-selector in-case there were instance types that weren't actually fit for the compute nodes that were getting included. But I suppose it doesn't really matter since you can just hand modify the list.
|
/cc @bwagner5 |
|
@rifelpet: GitHub didn't allow me to request PR reviews from the following users: bwagner5. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
bharath-123
force-pushed
the
fix/toolbox-cmd
branch
from
c548366
to
90ea91b
Compare
hakman
changed the title
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-kops-e2e-kubernetes-aws |
…-upstream-release-1.19 Automated cherry pick of #11048: remove instance-selector label
…-upstream-release-1.20 Automated cherry pick of #11048: remove instance-selector label
kops toolbox instance-selectorfails due to #10910 which improves the label validation. Making kops.k8s.io/instance-selector: "1" a node label rather than a cloud label should bypass this validation check. I also think it should make more sense to make it a node label rather than a cloud label.