Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create document on asset repositories #11654

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

johngmyers
Copy link
Member

@johngmyers johngmyers commented May 31, 2021

This covers the basics. There are a few things that could be done to polish the procedure.

My test environment doesn't have a non-S3 fileRepository, so I wasn't able to test that.

I'm wondering if asset phase should default to LifecycleIgnore.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 31, 2021
Comment on lines +52 to +55
An S3 bucket must be configured using the [regional naming conventions of S3](https://docs.aws.amazon.com/general/latest/gr/rande.html#s3_region).
A GCS bucket must be configured with a prefix of `https://storage.googleapis.com/`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure why fileRepository doesn't take VFS paths. Perhaps a future PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it doesn't accept a VFS path because it is used for NodeUp download too, and that is done via wget.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could convert from VFS form to https form for use by nodeup/userdata. That's a lot more natural than going the other way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could, but would have to be checked for access and maybe provide some override in case deduced http location is incorrect.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 1, 2021
@johngmyers johngmyers changed the title WIP Create document on asset repositories Create document on asset repositories Jun 1, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 1, 2021

## Copying assets into repositories

You can copy assets into their repositories either by running `kops update cluster --phase assets --create-kube-config=false --yes` or through an external process.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea when this was added? It is not what I would expect.
This is more of a toolbox thing than update cluster thing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that was added in #3025

mkdocs.yml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 7, 2021
@rifelpet
Copy link
Member

rifelpet commented Jun 7, 2021

/retest

@@ -58,4 +60,8 @@ This change only affects dedicated API server nodes and worker nodes. It does no

* It is no longer necessary to set `AWS_SDK_LOAD_CONFIG=1` in the environment when using AWS assumed roles with the `kops` CLI.

* There is a new command `kops get assets` for listing image and file assets used by a cluster.
It also includes a `--copy` flag to copy the assets to local repositories.
See the documentaion on [Using local asset repositories](../operations/asset-repository.md) for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See the documentaion on [Using local asset repositories](../operations/asset-repository.md) for more information.
See the documentation on [Using local asset repositories](../operations/asset-repository.md) for more information.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2021
@johngmyers johngmyers requested a review from rifelpet June 7, 2021 03:35
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ff9d0c8 into kubernetes:master Jun 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 7, 2021
@johngmyers johngmyers deleted the asset-doc branch June 7, 2021 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants