-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create document on asset repositories #11654
Conversation
An S3 bucket must be configured using the [regional naming conventions of S3](https://docs.aws.amazon.com/general/latest/gr/rande.html#s3_region). | ||
A GCS bucket must be configured with a prefix of `https://storage.googleapis.com/`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure why fileRepository
doesn't take VFS paths. Perhaps a future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it doesn't accept a VFS path because it is used for NodeUp download too, and that is done via wget.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could convert from VFS form to https form for use by nodeup/userdata. That's a lot more natural than going the other way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could, but would have to be checked for access and maybe provide some override in case deduced http location is incorrect.
docs/operations/asset-repository.md
Outdated
|
||
## Copying assets into repositories | ||
|
||
You can copy assets into their repositories either by running `kops update cluster --phase assets --create-kube-config=false --yes` or through an external process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea when this was added? It is not what I would expect.
This is more of a toolbox
thing than update cluster
thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that was added in #3025
140d27d
to
db1c929
Compare
/retest |
docs/releases/1.22-NOTES.md
Outdated
@@ -58,4 +60,8 @@ This change only affects dedicated API server nodes and worker nodes. It does no | |||
|
|||
* It is no longer necessary to set `AWS_SDK_LOAD_CONFIG=1` in the environment when using AWS assumed roles with the `kops` CLI. | |||
|
|||
* There is a new command `kops get assets` for listing image and file assets used by a cluster. | |||
It also includes a `--copy` flag to copy the assets to local repositories. | |||
See the documentaion on [Using local asset repositories](../operations/asset-repository.md) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the documentaion on [Using local asset repositories](../operations/asset-repository.md) for more information. | |
See the documentation on [Using local asset repositories](../operations/asset-repository.md) for more information. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This covers the basics. There are a few things that could be done to polish the procedure.
My test environment doesn't have a non-S3 fileRepository, so I wasn't able to test that.
I'm wondering if asset phase should default to
LifecycleIgnore
.