-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare OpenStack security groups deterministically #11741
Compare OpenStack security groups deterministically #11741
Conversation
Welcome @ederst! |
Hi @ederst. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This sorts the security groups of the port model and when querying the cloud, which will result in tasks comparing those slices deterministically.
0a31540
to
233145f
Compare
/ok-to-test |
/cc @olemarkus |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ernetes#11743-fork-release-1.20-bearingpoint Automated cherry pick of kubernetes#11741 kubernetes#11743 fork release 1.20 bearingpoint
This fixes #11740 by sorting the security groups of the port model and when querying the cloud, which will result in tasks comparing those slices deterministically.