Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make forwardToKubeDNS work in the NodeLocal DNSCache template #11743

Merged
merged 1 commit into from
Jun 11, 2021
Merged

Make forwardToKubeDNS work in the NodeLocal DNSCache template #11743

merged 1 commit into from
Jun 11, 2021

Conversation

ederst
Copy link
Contributor

@ederst ederst commented Jun 11, 2021 •
edited
Loading

This fixes #11742 which discusses the broken rendering of the Corefile of the NodeLocal DNSCache template when setting forwardToKubeDNS to false (or not setting it).

Previously, due to not dereferencing the bool pointer, the Corefile was always rendered with the true clause, due to checking the address instead of the actual value of the variable.

With this fix, the templating mechanism will actually respect the value of forwardToKubeDNS and render it accordingly.

@ederst
Make forwardToKubeDNS work in the NodeLocal DNSCache template
7f787de 
This fixes the rendering of the Corefile of the NodeLocal DNSCache
template when setting forwardToKubeDNS to false (or not setting it).

Previously, due to not dereferencing the bool pointer, the Corefile was
always rendered with the true clause, due to checking the address
instead of the actual value of the variable.

With this fix, the templating mechanism will actually respect the value
of forwardToKubeDNS and render it accordingly.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 11, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @ederst. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2021
@johngmyers
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2021
johngmyers
johngmyers approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@johngmyers johngmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 01777c8 into kubernetes:master Jun 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 11, 2021
This was referenced Jun 14, 2021
Merged
Merged
ederst added a commit to ederst/kops that referenced this pull request Jun 15, 2021
@ederst
Merge pull request #3 from ederst/automated-cherry-pick-of-#11741-kub…
f173d73 
…ernetes#11743-fork-release-1.20-bearingpoint

Automated cherry pick of kubernetes#11741 kubernetes#11743 fork release 1.20 bearingpoint
k8s-ci-robot added a commit that referenced this pull request Jun 16, 2021
@k8s-ci-robot
Merge pull request #11757 from ederst/automated-cherry-pick-of-#11741-#…
0ea4179 
…11743-origin-release-1.21

Automated cherry pick of #11741: Compare OpenStack security groups deterministically
#11743: Make forwardToKubeDNS work in the NodeLocal DNSCache template
@ederst ederst mentioned this pull request Apr 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers approved these changes

@mikesplain mikesplain Awaiting requested review from mikesplain

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.

ForwardToKubeDNS when using NodeLocal DNSCache is not working as expected
3 participants
@ederst @k8s-ci-robot @johngmyers