Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cilium] Add support for encryption via WireGuard #11786

Closed
wants to merge 1 commit into from
Closed

[cilium] Add support for encryption via WireGuard #11786

wants to merge 1 commit into from

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented Jun 16, 2021

In this commit, we enable users to choose WireGuard as their prefered
encryption type, leveraging this new feature from Cilium.

Ref: https://cilium.io/blog/2021/05/20/cilium-110#wireguard

Signed-off-by: dntosas ntosas@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @dntosas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/api needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 16, 2021
johngmyers
johngmyers reviewed Jun 16, 2021
View reviewed changes
pkg/apis/kops/validation/validation.go
}

if v.EncryptionType != "" {
allErrs = append(allErrs, IsValidValue(fldPath.Child("encryptionType"), &v.EncryptionType, []string{"ipsec", "wireguard"})...)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should do a Cilium version check for wireguard

@johngmyers
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2021
@johngmyers
Copy link
Member

/cc @olemarkus

@dntosas
[cilium] Add support for encryption via WireGuard
0f09a35 
In this commit, we enable users to choose WireGuard as their prefered
encryption type, leveraging this new feature from Cilium.

Ref: https://cilium.io/blog/2021/05/20/cilium-110#wireguard

Signed-off-by: dntosas <ntosas@gmail.com>
@olemarkus
Copy link
Member

/retest

@olemarkus
Copy link
Member

Ubuntu LTS requires the wireguard package being installed, I believe.
If you set encryptionConfig I think kOps will also require the ciliumpassword secret. Is this one needed for wireguard?

It would also be nice to add some docs on how to enable wireguard.

@johngmyers
Copy link
Member

/assign @olemarkus

olemarkus
olemarkus requested changes Jul 4, 2021
View reviewed changes
Copy link
Member

@olemarkus olemarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from olemarkus after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dntosas
Copy link
Contributor Author

dntosas commented Jul 9, 2021

FYI, will be able continue it early next week team ^^

@ghost
Copy link

ghost commented Aug 5, 2021

Hi @dntosas,
I'm really interested to use Cilium with Wireguard via Kops. Any update on this PR? 😢

@olemarkus olemarkus mentioned this pull request Aug 15, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 17, 2021
@k8s-ci-robot
Copy link
Contributor

@dntosas: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@olemarkus
Copy link
Member

/close

Closed in favour of #12158

@k8s-ci-robot
Copy link
Contributor

@olemarkus: Closed this PR.

In response to this:

/close

Closed in favour of #12158

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers left review comments

@olemarkus olemarkus olemarkus requested changes

@joshbranham joshbranham Awaiting requested review from joshbranham

Assignees

@olemarkus olemarkus

Labels
area/addons area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dntosas @k8s-ci-robot @johngmyers @olemarkus