-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump the version of gophercloud #11788
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @cardoe! |
Hi @cardoe. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I've signed the CLA. |
/ok-to-test |
Since the v1.19.0 release of kOps the OpenStack integration has been broken because gophercloud made a change to start escaping all path names for files stored in swift. kOps used a file with a slash in it which was getting escaped and then not handled correctly. This has been fixed in upstream gophercloud with gophercloud/gophercloud#2160 which was included in gophercloud v0.18.0. Bump is for issue kubernetes#9933.
Apologizes @hakman, I didn't use |
It appears there was a timeout in the NFS PV side. That shouldn't be anything related to gophercloud. I suspect if we re-ran it that it would pass. |
All our PRs are failing that test. I think someone broke the test itself on the k/k side |
/retest |
/retest |
/assign @rdrgmnzs I believe is the correct step for me since I have the lgtm tag with passing tests. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@olemarkus do you think this is something that should be addressed in 1.21.0 also? |
Maybe if @zetaab is able to run a test. I unfortunately cannot so I cannot say yes with confidence |
I would appreciate a backport @zetaab . How can I help make that happen? |
I've made #11830 but I'm not sure if that's helpful. |
Since the v1.19.0 release of kOps the OpenStack integration has been
broken because gophercloud made a change to start escaping all path
names for files stored in swift. kOps used a file with a slash in it
which was getting escaped and then not handled correctly. This has been
fixed in upstream gophercloud with gophercloud/gophercloud#2160 which
was included in gophercloud v0.18.0. Bump to that version to fix #9933.