Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump the version of gophercloud #11788

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Conversation

cardoe
Copy link
Contributor

@cardoe cardoe commented Jun 16, 2021

Since the v1.19.0 release of kOps the OpenStack integration has been
broken because gophercloud made a change to start escaping all path
names for files stored in swift. kOps used a file with a slash in it
which was getting escaped and then not handled correctly. This has been
fixed in upstream gophercloud with gophercloud/gophercloud#2160 which
was included in gophercloud v0.18.0. Bump to that version to fix #9933.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 16, 2021
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 16, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @cardoe!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 16, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @cardoe. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 16, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 16, 2021
@cardoe
Copy link
Contributor Author

cardoe commented Jun 16, 2021

I've signed the CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 16, 2021
@hakman
Copy link
Member

hakman commented Jun 16, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 16, 2021
Since the v1.19.0 release of kOps the OpenStack integration has been
broken because gophercloud made a change to start escaping all path
names for files stored in swift. kOps used a file with a slash in it
which was getting escaped and then not handled correctly. This has been
fixed in upstream gophercloud with gophercloud/gophercloud#2160 which
was included in gophercloud v0.18.0. Bump is for issue kubernetes#9933.
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 16, 2021
@cardoe
Copy link
Contributor Author

cardoe commented Jun 16, 2021

Apologizes @hakman, I didn't use make gomod and instead just used go mod directly. That's been fixed now if you can give me the ok-to-test again.

@hakman
Copy link
Member

hakman commented Jun 16, 2021

No worries @cardoe.
/lgtm
/cc @zetaab

@k8s-ci-robot k8s-ci-robot requested a review from zetaab June 16, 2021 17:25
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2021
@cardoe
Copy link
Contributor Author

cardoe commented Jun 16, 2021

It appears there was a timeout in the NFS PV side. That shouldn't be anything related to gophercloud. I suspect if we re-ran it that it would pass.

@olemarkus
Copy link
Member

All our PRs are failing that test. I think someone broke the test itself on the k/k side

@johngmyers
Copy link
Member

/retest

@hakman
Copy link
Member

hakman commented Jun 17, 2021

/retest

@cardoe
Copy link
Contributor Author

cardoe commented Jun 19, 2021

/assign @rdrgmnzs

I believe is the correct step for me since I have the lgtm tag with passing tests.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2021
@hakman
Copy link
Member

hakman commented Jun 19, 2021

@olemarkus do you think this is something that should be addressed in 1.21.0 also?

@olemarkus
Copy link
Member

Maybe if @zetaab is able to run a test. I unfortunately cannot so I cannot say yes with confidence

@k8s-ci-robot k8s-ci-robot merged commit 23ab07e into kubernetes:master Jun 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 19, 2021
@cardoe cardoe deleted the fix-swift branch June 19, 2021 22:43
@cardoe
Copy link
Contributor Author

cardoe commented Jun 21, 2021

I would appreciate a backport @zetaab . How can I help make that happen?

@cardoe
Copy link
Contributor Author

cardoe commented Jun 21, 2021

I've made #11830 but I'm not sure if that's helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression with writing to swift container between version 1.18.0 and 1.19.0-alpha3
6 participants