Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write config as ManagedFile #11796

Merged
merged 2 commits into from
Jun 27, 2021
Merged

Write config as ManagedFile #11796

merged 2 commits into from
Jun 27, 2021

Conversation

johngmyers
Copy link
Member

@johngmyers johngmyers commented Jun 18, 2021 •
edited
Loading

In preparation for #9621

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 18, 2021
@johngmyers johngmyers force-pushed the fullcluster-managedfile branch 2 times, most recently from 7623abd to 19f15ce Compare June 18, 2021 05:55
@johngmyers johngmyers changed the title WIP Write config as ManagedFile Write config as ManagedFile Jun 18, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit dd8d2d9 into kubernetes:master Jun 27, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 27, 2021
@johngmyers johngmyers deleted the fullcluster-managedfile branch June 27, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@joshbranham joshbranham Awaiting requested review from joshbranham

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/kops-controller area/nodeup area/provider/alicloud Issues or PRs related to alicloud provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
3 participants
@johngmyers @k8s-ci-robot @olemarkus