Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use etcd v3.5.0 for Kubernetes 1.22+ #11941

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Use etcd v3.5.0 for Kubernetes 1.22+ #11941

merged 2 commits into from
Jul 8, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Jul 6, 2021

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 6, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 6, 2021
@olemarkus
Copy link
Member

Maybe we should do a k8s upgrade test for this PR as well.

@hakman
Copy link
Member Author

hakman commented Jul 7, 2021

Maybe we should do a k8s upgrade test for this PR as well.

@olemarkus I agree, we should try it. Should be pretty much fine, as it's tested in the etcd-manager integration tests.

@hakman
Copy link
Member Author

hakman commented Jul 7, 2021

/test pull-kops-e2e-k8s-ci-ha

@kubernetes kubernetes deleted a comment from k8s-ci-robot Jul 7, 2021
@hakman
Copy link
Member Author

hakman commented Jul 7, 2021

/test pull-kops-e2e-k8s-ci-ha

1 similar comment
@hakman
Copy link
Member Author

hakman commented Jul 7, 2021

/test pull-kops-e2e-k8s-ci-ha

@hakman
Copy link
Member Author

hakman commented Jul 8, 2021

/test pull-kops-e2e-k8s-ci-ha

@hakman hakman changed the title [WIP] Use etcd v3.5.0 for Kubernetes 1.22+ Use etcd v3.5.0 for Kubernetes 1.22+ Jul 8, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 8, 2021
@hakman hakman requested a review from johngmyers July 8, 2021 19:25
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit b358037 into kubernetes:master Jul 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 8, 2021
@hakman hakman deleted the etcd-3.5.0 branch October 22, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers approved these changes

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @olemarkus @k8s-ci-robot @johngmyers