Fix MetricsGrabber skip regex condition #12165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release/latest version marker will stay on 1.23.0-alpha.0 until another 1.23 pre-release is tagged which isnt for a while. This will skip the MetricsGrabber test for that tag which has been fixed in master. Once a new 1.23 pre-release has been tagged we can remove this. Alternatively we migrate all jobs off of the release/latest version marker since it isn't particularly valuable.
k8s-ci-robot
added
do-not-merge/hold
hakman
approved these changes
Aug 17, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release/latest version marker will stay on 1.23.0-alpha.0 until another 1.23 pre-release is tagged which isn't for a while.
This will skip the MetricsGrabber test for that tag which has been fixed in master (example failing job). This won't match CI builds since they have a commit hash suffix
Once a new 1.23 pre-release has been tagged we can remove this.
Alternatively we migrate all jobs off of the release/latest version marker since it isn't particularly valuable.
/hold until 1.22.1 is tagged on Wednesday which includes the cherry-picked fix (kubernetes/kubernetes#104154) so we'll no longer need to skip the test on k8s 1.22 jobs.