New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/apis/kops: Allow configuring dockerd --max-* upload and download concurrency and retry options. #12320
pkg/apis/kops: Allow configuring dockerd --max-* upload and download concurrency and retry options. #12320
Conversation
Welcome @anthonyrisinger! |
Hi @anthonyrisinger. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Same patch with all tests passing is here (only author/committer email is different) https://github.com/ZipRecruiter/kops/actions/runs/1230217292 |
/ok-to-test |
What's the use case for setting |
Needs to update the v1alpha3 API as well, now that #12406 has merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anthonyrisinger could you address the v1alpha3 issue and answer the question about max-concurrent-uploads
I updated everything manually, hopefully it translated fine. We run all of our build infrastructure on dedicated kops-managed clusters (where a single node might run a half dozen or more builds at a time), and despite other bottlenecks in play, the increased upload concurrency does help us push docker layers to ECR faster. |
I tried to run |
@anthonyrisinger You need to add the changes to |
…concurrency and retry options. YAML config options are maxConcurrentDownloads, maxConcurrentUploads, and maxDownloadAttempts. Defaults are maxConcurrentDownloads=3, maxConcurrentUploads=5, and maxDownloadAttempts=5.
Thank you! I think we're good now (still pending) but let me know if anything else needs updating. |
/retest |
/test pull-kops-e2e-cni-cilium-ipv6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @anthonyrisinger!
/test pull-kops-e2e-cni-calico-ipv6
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-upstream-release-1.22 Automated cherry pick of #12320: pkg/apis/kops: Allow configuring dockerd --max-* upload and
YAML config options are maxConcurrentDownloads, maxConcurrentUploads, and maxDownloadAttempts.
Defaults are maxConcurrentDownloads=3, maxConcurrentUploads=5, and maxDownloadAttempts=5.