-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create v1alpha3 apiVersion #12406
Create v1alpha3 apiVersion #12406
Conversation
84899ab
to
404b0a2
Compare
404b0a2
to
6300993
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the CHANGES.md nit...
/lgtm
DONE | ||
|
||
* Rename zones -> subnets | ||
|
||
* Split out the utility subnet from zones | ||
|
||
* Etcd clusters will be defined in terms of IGs not zones | ||
|
||
* Split AdminAccess -> SSHAccess & APIAccess | ||
|
||
* Dropped Multizone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be update or removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's fix that in a follow-up PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an alternative to #9178
Introduce a v1alpha3 API as a copy of v1alpha2. We can then take multiple kOps release cycles to refine the new API, until we are ready to publish it as v1beta1.
The v1alpha3 is not intended to be used in production systems.