Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create v1alpha3 apiVersion #12406

Merged
merged 3 commits into from
Oct 2, 2021
Merged

Conversation

johngmyers
Copy link
Member

This is an alternative to #9178

Introduce a v1alpha3 API as a copy of v1alpha2. We can then take multiple kOps release cycles to refine the new API, until we are ready to publish it as v1beta1.

The v1alpha3 is not intended to be used in production systems.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 24, 2021
@johngmyers johngmyers force-pushed the v1alpha3 branch 2 times, most recently from 84899ab to 404b0a2 Compare September 24, 2021 06:22
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the CHANGES.md nit...
/lgtm

Comment on lines +11 to +21
DONE

* Rename zones -> subnets

* Split out the utility subnet from zones

* Etcd clusters will be defined in terms of IGs not zones

* Split AdminAccess -> SSHAccess & APIAccess

* Dropped Multizone
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be update or removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix that in a follow-up PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me.

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 2, 2021
@hakman hakman removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit a610756 into kubernetes:master Oct 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 2, 2021
@johngmyers johngmyers deleted the v1alpha3 branch October 2, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants