Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EC2 and Metadata IPv6 endpoints in IPv6 mode for EBS CSI Driver #12349

Merged
merged 1 commit into from
Sep 18, 2021
Merged

Use EC2 and Metadata IPv6 endpoints in IPv6 mode for EBS CSI Driver #12349

merged 1 commit into from
Sep 18, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Sep 18, 2021

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/addons labels Sep 18, 2021
olemarkus
olemarkus approved these changes Sep 18, 2021
View reviewed changes
Copy link
Member

@olemarkus olemarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent like half a day looking for these config options, but couldn't find them ... Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2021
@hakman
Copy link
Member Author

hakman commented Sep 18, 2021

I spent like half a day looking for these config options, but couldn't find them ... Thanks!

Yes, they are fairly new, but seems to work pretty well with them.
The only catch is that dual-stack endpoints are only available for select regions:
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/Using_Endpoints.html#ipv6

@hakman hakman mentioned this pull request Sep 18, 2021
Closed
@k8s-ci-robot k8s-ci-robot merged commit f5cc9f6 into kubernetes:master Sep 18, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 18, 2021
@hakman hakman deleted the aws-ebs-csi-ipv6 branch September 18, 2021 12:02
This was referenced Sep 18, 2021
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 19, 2021
@k8s-ci-robot
Merge pull request #12358 from hakman/automated-cherry-pick-of-#12349-#…
c308726 
…12353-upstream-release-1.22

Automated cherry pick of #12349: Use EC2 and Metadata IPv6 endpoints in IPv6 mode for EBS CSI
#12353: Fix EC2 IPv6 endpoint for EBS CSI Driver controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hakman @k8s-ci-robot @olemarkus