-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specific taints to dns-controller. #12389
Conversation
For reference, we believe this might be contributing to our upgrade test failures: https://testgrid.k8s.io/kops-misc#kops-aws-upgrade-k121-ko121-to-klatest-kolatest the this looks good to me once hack/update-expected is ran |
Also set kops-controller as cluster critical, not node critical
363de05
to
f06fcc5
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…389-origin-release-1.22 Automated cherry pick of #12389: Add specific taints to dns-controller.
Also set kops-controller as cluster critical, not node critical