-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow aws-iam-authenticator to be scheduled onto dedicated apiserver nodes #12426
Conversation
Makes sense to me to tolerate the apiserver taint; apiserver talks to the authentication webhook over a localhost URL, so it has to run on every apiserver pod. One question would be whether we should be running it with a universal toleration, but we can discuss this at office hours sometime. Would be good to get some rules here! /approve I think we should @olemarkus approve though, as IIRC they were the main author of the dedicated apiserver nodes. /hold for olemarkus to take a look /assign @olemarkus |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks good /hold cancel |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
…26-origin-release-1.22 Automated cherry pick of #12426: Allow aws-iam-authenticator to be scheduled onto dedicated
Also adding the CCM toleration to match dns-controller in #12389
Fixes #12390