Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ignore channel value in toolbox template #12464

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

hakman
Copy link
Member

@hakman hakman commented Oct 2, 2021

Fixes: #12447

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Oct 2, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 2, 2021
@hakman hakman linked an issue Oct 2, 2021 that may be closed by this pull request
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 92d0fff into kubernetes:release-1.21 Oct 2, 2021
@hakman hakman deleted the fix-template-channel branch October 2, 2021 08:07
k8s-ci-robot added a commit that referenced this pull request Oct 2, 2021
…-upstream-release-1.20

Automated cherry pick of #12464: Don't ignore channel value in toolbox template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kops toolbox template does not work in isolated environment.
3 participants