fix ipv4+ipv6 sec groups/listeners in OpenStack #13093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/L
k8s-ci-robot
added
the
area/provider/openstack
|
/kind bug |
|
@olemarkus could you help reviewing this? Currently master / release-1.23 does not work for openstack |
olemarkus
approved these changes
Jan 16, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Jan 18, 2022
…-origin-release-1.23 Automated cherry pick of #13093: fix ipv4+ipv6 sec groups/listeners in OpenStack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems that #13032 is not working correctly when updating the existing cluster. It do solves the problem that cluster can be created from the scratch, but updating existing clusters does not work at all.
This PR is modifying security groups working correctly. However, there is no easy way to make api loadbalancer to support ipv6 addresses like this. It needs more investigation how that can be done. I am pretty sure that none is using ipv6 api loadbalancer because it has not been supported by kOps
cc @igene