-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DescribeRegions to nodeup privs #13114
Add DescribeRegions to nodeup privs #13114
Conversation
/retest |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…114-origin-release-1.23 Automated cherry pick of #13114: Add DescribeRegions to nodeup privs
/retest |
amazon-vpc test failed because the node's limit of 35 pods prevented an additional pod from scheduling. Perhaps the amazonvpc e2e test needs to use a larger instance type? |
/retest |
Or enable prefix mode by default |
Not a bad idea. Perhaps by default for k8s >= 1.23? |
In some cases, buildCloud will eventually end up in a DescribeRegion call, but this has been removed from nodeup. This PR adds it back in again.
Fixes #13079