Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GPU in OpenStack #13330

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Support GPU in OpenStack #13330

merged 2 commits into from
Mar 16, 2022

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Mar 4, 2022 •
edited
Loading

fixes #12750

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 4, 2022
@k8s-ci-robot k8s-ci-robot added area/api area/nodeup area/provider/openstack Issues or PRs related to openstack provider labels Mar 4, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2022
@zetaab zetaab changed the title wip: Support GPU in OpenStack Support GPU in OpenStack Mar 8, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2022
@zetaab
Copy link
Member Author

zetaab commented Mar 8, 2022

@olemarkus as you did that AWS support, could you check this? With this PR I can get GPUs visible in OpenStack and everything looks good.

@zetaab
Copy link
Member Author

zetaab commented Mar 8, 2022

/test pull-kops-e2e-kubernetes-aws

2 similar comments
@zetaab
Copy link
Member Author

zetaab commented Mar 8, 2022

/test pull-kops-e2e-kubernetes-aws

@zetaab
Copy link
Member Author

zetaab commented Mar 9, 2022

/test pull-kops-e2e-kubernetes-aws

@zetaab zetaab requested a review from olemarkus March 9, 2022 07:05
@zetaab
Copy link
Member Author

zetaab commented Mar 10, 2022

/hold

1 similar comment
@zetaab
Copy link
Member Author

zetaab commented Mar 10, 2022

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 10, 2022
@zetaab zetaab force-pushed the feature/openstackgpu branch 4 times, most recently from 4bdc6e5 to ae139b8 Compare March 10, 2022 11:03
@k8s-ci-robot k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 10, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 10, 2022
@zetaab zetaab force-pushed the feature/openstackgpu branch 2 times, most recently from 0c9d7cd to c01e5a6 Compare March 10, 2022 14:57
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 10, 2022
@zetaab
Copy link
Member Author

zetaab commented Mar 10, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2022
@zetaab
Copy link
Member Author

zetaab commented Mar 11, 2022

/test pull-kops-e2e-kubernetes-aws

/test pull-kops-verify-golangci-lint

zetaab
zetaab commented Mar 11, 2022
View reviewed changes
upup/pkg/fi/cloudup/apply_cluster.go Outdated
}

if config.NvidiaGPU != nil && config.NvidiaGPU.DriverPackage == "" {
config.NvidiaGPU.DriverPackage = "nvidia-headless-460-server"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should perhaps store this const to same common place. This is now defined in two files as hardcoded, which would be the correct place to store this information? there are wellknownports etc should we add something new?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could certainly be moved to a const. Perhaps in the API package.

Here we are doing the merging in two locations as well. Didn't it work to move this to a function similar to how we merge workpool?

@zetaab
Copy link
Member Author

zetaab commented Mar 14, 2022

/test pull-kops-e2e-kubernetes-aws

@zetaab
Copy link
Member Author

zetaab commented Mar 15, 2022

ping @olemarkus

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 16, 2022
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

1 similar comment
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 404e411 into kubernetes:master Mar 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 16, 2022
@zetaab zetaab deleted the feature/openstackgpu branch March 16, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@drekle drekle Awaiting requested review from drekle

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation area/nodeup area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

Container runtime configuration should be per instanceGroup
4 participants
@zetaab @k8s-ci-robot @k8s-triage-robot @olemarkus