Exit rolling updates when encountering specific errors

[jandersen-plaid]

Fixes #14176

Add a new error to instancegroups which is returned when cluster validation times out. Then, check this error during cluster node and apiserver instancegroup rolls. If the cluster fails to be validated within the timeout then it is unlikely to succeed on subsequent node rolls, so the preference is to exit the cluster roll (to allow operators to fix the cluster validation issue).

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: jandersen-plaid (40caf71)

[k8s-ci-robot]

Welcome @jandersen-plaid!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jandersen-plaid. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[olemarkus]

I'd rather not add a flag for this. I think it is enough to inspect the returned error and return directly if it does not make sense to continue.

[johngmyers]

I think I'd prefer this be the default or only option.

/hold
/kind office-hours

[johngmyers]

I believe the history was that the update on the IG would previously wait forever, not fail.

[olemarkus]

If a control plane IG fails, we already directly return an error. That is by far the most important behavior. If an IG fails and kOps keeps going to the next, and keeps going to the next and continues to gracefully drain and terminate nodes makes sense.

But in the case of a validation error, it doesn't make sense to keep going as kOps won't succeed with the next IG either.

[olemarkus]

This looks good.

I think it is worth adding a brief explanation to the notes about the change in behavior. Something like:

* As of 1.24, kOps no longer hung indefinitely on eviction errors, but timed out after 15 minutes by default. After the timeout kOps will carry on to the next InstanceGroup. As of kOps 1.26, kOps will no longer carry on if a cluster validation error is encountered.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [olemarkus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[olemarkus]

@johngmyers you still want to hold this one?

[johngmyers]

/hold cancel

[johngmyers]

/retest