Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-node-termination-handler to match node using providerID instead of AWS DNS name #14244

Merged
merged 1 commit into from
Sep 8, 2022
Merged

aws-node-termination-handler to match node using providerID instead of AWS DNS name #14244

merged 1 commit into from
Sep 8, 2022

Conversation

anthonyhaussman
Copy link
Contributor

on aws-node-termination-handler, fetch node name through Kubernetes node .spec.providerID since Kops use InstanceID as node name.

Ref:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 7, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @anthonyhaussman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 7, 2022
@olemarkus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 7, 2022
@olemarkus olemarkus changed the title [aws-node-termination-handler] Add option to fetch node name through Kubernetes node .spec.providerID aws-node-termination-handler to match node using providerID instead of AWS DNS name Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 7, 2022
This was referenced Sep 7, 2022
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 7, 2022
@k8s-ci-robot
Merge pull request #14245 from olemarkus/automated-cherry-pick-of-#14…
4e96978 
…244-origin-release-1.25

Automated cherry pick of #14244: aws-node-termination-handler: Add option to fetch node name
k8s-ci-robot added a commit that referenced this pull request Sep 7, 2022
@k8s-ci-robot
Merge pull request #14246 from olemarkus/automated-cherry-pick-of-#14…
fa02a8c 
…244-origin-release-1.24

Automated cherry pick of #14244: aws-node-termination-handler: Add option to fetch node name
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

4 similar comments
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@hakman
Copy link
Member

hakman commented Sep 8, 2022

/skip

@kubernetes kubernetes deleted a comment from k8s-ci-robot Sep 8, 2022
@hakman hakman closed this Sep 8, 2022
@hakman hakman reopened this Sep 8, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2022
@anthonyhaussman
aws-node-termination-handler: Add option to fetch node name through K…
af1ab75 
…ubernetes node `.spec.providerID`

Fetch node name through Kubernetes node `.spec.providerID` since Kops use InstanceID as node name.
 - aws/aws-node-termination-handler@701db81
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hakman
Copy link
Member

hakman commented Sep 8, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit f34d0f1 into kubernetes:master Sep 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Sep 8, 2022
@anthonyhaussman anthonyhaussman deleted the feat/tone/node-termination-handler_use_provider_id branch September 8, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus olemarkus approved these changes

@hakman hakman Awaiting requested review from hakman

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
5 participants
@anthonyhaussman @k8s-ci-robot @olemarkus @k8s-triage-robot @hakman