Do not include tags when searching existing volumes in OpenStack

[zetaab]

fixes #14922

if we include tags when searching volumes, it basically means that we cannot modify tags at all.

After this PR the kops update cluster output is: (it will add tag k8s.io/role/control-plane: 1 to all volumes)

Will modify resources:
  Volume/espsti.etcd-events.sre-sandbox.k8s.local
        Tags                     {k8s.io/role/master: 1, KubernetesCluster: sre-sandbox.k8s.local, k8s.io/etcd/events: espsti/espsti,esptnl,helpa} -> {k8s.io/etcd/events: espsti/espsti,esptnl,helpa, k8s.io/role/control-plane: 1, k8s.io/role/master: 1, KubernetesCluster: sre-sandbox.k8s.local}

  Volume/espsti.etcd-main.sre-sandbox.k8s.local
        Tags                     {KubernetesCluster: sre-sandbox.k8s.local, k8s.io/etcd/main: espsti/espsti,esptnl,helpa, k8s.io/role/master: 1} -> {k8s.io/etcd/main: espsti/espsti,esptnl,helpa, k8s.io/role/control-plane: 1, k8s.io/role/master: 1, KubernetesCluster: sre-sandbox.k8s.local}

  Volume/esptnl.etcd-events.sre-sandbox.k8s.local
        Tags                     {KubernetesCluster: sre-sandbox.k8s.local, k8s.io/etcd/events: esptnl/espsti,esptnl,helpa, k8s.io/role/master: 1} -> {k8s.io/etcd/events: esptnl/espsti,esptnl,helpa, k8s.io/role/control-plane: 1, k8s.io/role/master: 1, KubernetesCluster: sre-sandbox.k8s.local}

  Volume/esptnl.etcd-main.sre-sandbox.k8s.local
        Tags                     {k8s.io/etcd/main: esptnl/espsti,esptnl,helpa, k8s.io/role/master: 1, KubernetesCluster: sre-sandbox.k8s.local} -> {k8s.io/etcd/main: esptnl/espsti,esptnl,helpa, k8s.io/role/control-plane: 1, k8s.io/role/master: 1, KubernetesCluster: sre-sandbox.k8s.local}

  Volume/helpa.etcd-events.sre-sandbox.k8s.local
        Tags                     {KubernetesCluster: sre-sandbox.k8s.local, k8s.io/etcd/events: helpa/espsti,esptnl,helpa, k8s.io/role/master: 1} -> {k8s.io/role/control-plane: 1, k8s.io/role/master: 1, KubernetesCluster: sre-sandbox.k8s.local, k8s.io/etcd/events: helpa/espsti,esptnl,helpa}

  Volume/helpa.etcd-main.sre-sandbox.k8s.local
        Tags                     {k8s.io/role/master: 1, KubernetesCluster: sre-sandbox.k8s.local, k8s.io/etcd/main: helpa/espsti,esptnl,helpa} -> {k8s.io/etcd/main: helpa/espsti,esptnl,helpa, k8s.io/role/control-plane: 1, k8s.io/role/master: 1, KubernetesCluster: sre-sandbox.k8s.local}

so instead of creating new volumes it will update existing volume tags. Volume tag update is handled already in https://github.com/kubernetes/kops/blob/master/upup/pkg/fi/cloudup/openstacktasks/volume.go#L151-L158 and I verified that this works like should.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hakman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

@zetaab Consider removing that tag altogether. It is pretty pointless.

[hakman]

Seems docs generation failed. Not sure if possible to force it to re-run.

[zetaab]

@hakman force pushed the commit again but you need add lgtm again

[hakman]

/lgtm