Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotinst: update docs about setting the VNG Size Limits in Launch Spec #15355

Conversation

IdanShohamNetApp
Copy link
Contributor

This PR update spot-ocean doc about setting support for VNG size limits in launch spec.

k8s-ci-robot and others added 30 commits February 10, 2023 15:15
…cated-command-with-environment-file

Replace deprecated command with environment file
Makes for easier debugging.
It's a little simpler and should speed up our boot.
Prefer explicit error checking to the "fallthrough" pattern.
Now we have some IPv6 support, we were printing an empty address when
machines did not have an IPv6 address.
hetzner: support toolbox dump of instances
digitalocean: don't print empty IP addresses
…object_acl

gce terraform: Use google_storage_object_acl
…blenodeu

Revert "disable kops-configuration.service after successful execution"
Update remaining references from k8s.gcr.io to registry.k8s.io
This means we don't need to pre-upload our SSH keys.
We previously tested that we could not generate 4 zones in a region,
but now us-east-1 has 6 zones, so we need to update the tests to fail
only when even more zones are requested.
DigitalOcean: Support SSH key provisioning
kubetest2-kops: update tests for new zones
remove AWS S3 access from nodes if using none dns
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 2, 2023
@Shimiazoulai Shimiazoulai force-pushed the feature/update_setting_vng_max_min_size_in_docs branch from 282fb93 to 80766b0 Compare July 13, 2023 11:20
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/api area/channels and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zetaab for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/kops-controller area/nodeup area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/gcp Issues or PRs related to gcp provider area/provider/hetzner Issues or PRs related to Hetzner provider area/provider/openstack Issues or PRs related to openstack provider area/provider/scaleway Issues or PRs related to Scaleway provider area/provider/spotinst Issues or PRs related to spotinst provider area/rolling-update labels Jul 13, 2023
@IdanShohamNetApp
Copy link
Contributor Author

IdanShohamNetApp commented Jul 13, 2023

a new PR regarding this change will be open
new PR #15631

@IdanShohamNetApp IdanShohamNetApp deleted the feature/update_setting_vng_max_min_size_in_docs branch July 13, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api area/channels area/documentation area/kops-controller area/nodeup area/provider/aws Issues or PRs related to aws provider area/provider/azure Issues or PRs related to azure provider area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/gcp Issues or PRs related to gcp provider area/provider/hetzner Issues or PRs related to Hetzner provider area/provider/openstack Issues or PRs related to openstack provider area/provider/scaleway Issues or PRs related to Scaleway provider area/provider/spotinst Issues or PRs related to spotinst provider area/rolling-update cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/contains-merge-commits needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.