Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openstack: Include kube-apiserver controlplane ports in dns=none #16271

Merged
merged 2 commits into from Jan 22, 2024

Conversation

zetaab
Copy link
Member

@zetaab zetaab commented Jan 22, 2024

fixes #16270

see discussion (or actually my wall of text) in issue

cc @justinsb @hakman

with this change I can get working kube_env.yaml like following in normal node:

root@nodes-xx-kybe4u:/home/ubuntu# cat /opt/kops/conf/kube_env.yaml 
APIServerIPs:
- 10.2.131.13
- 10.2.192.39
- 10.2.65.84
CloudProvider: openstack
ClusterName: jessetesti.k8s.local
ConfigServer:
  CACertificates: |
    -----BEGIN CERTIFICATE-----
    snip
    TdTyytTpZ/HeOvfbyt6p2qd3I5iaJb2W9Ydo3RROsYAi6p2fMDa/IATzSAQ=
    -----END CERTIFICATE-----
  servers:
  - https://10.2.131.13:3988/
  - https://10.2.192.39:3988/
  - https://10.2.65.84:3988/
InstanceGroupName: nodes-xx
InstanceGroupRole: Node
NodeupConfigHash: HT1Osvmi/hpjF1M1oH8RuCaqyhiO2/D41/wdkQACILE=
% kubectl get nodes
NAME                          STATUS   ROLES           AGE    VERSION
control-plane-xx-t70fjk   Ready    control-plane   106s   v1.29.1
control-plane-yy-1xqslp   Ready    control-plane   116s   v1.29.1
control-plane-zz-mwzfde    Ready    control-plane   112s   v1.29.1
nodes-xx-9e0jht           Ready    node            43s    v1.29.1
nodes-yy-wflops           Ready    node            45s    v1.29.1
nodes-zz-kybe4u            Ready    node            46s    v1.29.1

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/provider/openstack Issues or PRs related to openstack provider labels Jan 22, 2024
@hakman hakman changed the title include kube-apiserver controlplane ports in dns=none openstack: Include kube-apiserver controlplane ports in dns=none Jan 22, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 22, 2024
@zetaab
Copy link
Member Author

zetaab commented Jan 22, 2024

/test pull-kops-e2e-k8s-aws-calico

@k8s-ci-robot k8s-ci-robot merged commit a793967 into kubernetes:master Jan 22, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Jan 22, 2024
@zetaab zetaab deleted the fixopenstackdnsnone branch January 23, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nodeup will fail in nodes
3 participants