Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openstack: Include kube-apiserver controlplane ports in dns=none #16271

Merged
merged 2 commits into from Jan 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/model/openstackmodel/servergroup.go
Expand Up @@ -201,7 +201,7 @@ func (b *ServerGroupModelBuilder) buildInstances(c *fi.CloudupModelBuilderContex
c.AddTask(portTask)

if b.Cluster.UsesNoneDNS() && ig.Spec.Role == kops.InstanceGroupRoleControlPlane {
portTask.ForAPIServer = true
portTask.WellKnownServices = append(portTask.WellKnownServices, wellknownservices.KubeAPIServer)
}

metaWithName := make(map[string]string)
Expand Down
Expand Up @@ -26,7 +26,6 @@ Port:
AdditionalSecurityGroups:
- additional-sg
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -56,6 +55,7 @@ Port:
- KopsInstanceGroup=node
- KopsName=port-node-1
- KubernetesCluster=cluster
WellKnownServices: null
Region: region
Role: Node
SSHKey: kubernetes.cluster-ba_d8_85_a0_5b_50_b0_01_e0_b2_b0_ae_5d_f6_7a_d1
Expand Down Expand Up @@ -196,7 +196,6 @@ PublicACL: null
AdditionalSecurityGroups:
- additional-sg
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -226,6 +225,7 @@ Tags:
- KopsInstanceGroup=node
- KopsName=port-node-1
- KubernetesCluster=cluster
WellKnownServices: null
---
ClusterName: cluster
ID: null
Expand Down
Expand Up @@ -26,7 +26,6 @@ Name: node-1-cluster
Port:
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -56,6 +55,7 @@ Port:
- KopsInstanceGroup=node
- KopsName=port-node-1
- KubernetesCluster=cluster
WellKnownServices: null
Region: region
Role: Node
SSHKey: kubernetes.cluster-ba_d8_85_a0_5b_50_b0_01_e0_b2_b0_ae_5d_f6_7a_d1
Expand Down Expand Up @@ -194,7 +194,6 @@ PublicACL: null
---
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -224,6 +223,7 @@ Tags:
- KopsInstanceGroup=node
- KopsName=port-node-1
- KubernetesCluster=cluster
WellKnownServices: null
---
ClusterName: cluster
ID: null
Expand Down
Expand Up @@ -26,7 +26,6 @@ Name: node-1-cluster
Port:
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -56,6 +55,7 @@ Port:
- KopsInstanceGroup=node
- KopsName=port-node-1
- KubernetesCluster=cluster
WellKnownServices: null
Region: region
Role: Node
SSHKey: kubernetes.cluster-ba_d8_85_a0_5b_50_b0_01_e0_b2_b0_ae_5d_f6_7a_d1
Expand Down Expand Up @@ -194,7 +194,6 @@ PublicACL: null
---
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -224,6 +223,7 @@ Tags:
- KopsInstanceGroup=node
- KopsName=port-node-1
- KubernetesCluster=cluster
WellKnownServices: null
---
ClusterName: cluster
ID: null
Expand Down
Expand Up @@ -28,7 +28,6 @@ Port:
- ip_address: 10.123.0.1
mac_address: 12:34:56:78:90:AB
- ip_address: 192.168.0.0/16
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -58,6 +57,7 @@ Port:
- KopsInstanceGroup=node
- KopsName=port-node-1
- KubernetesCluster=cluster
WellKnownServices: null
Region: region
Role: Node
SSHKey: kubernetes.cluster-ba_d8_85_a0_5b_50_b0_01_e0_b2_b0_ae_5d_f6_7a_d1
Expand Down Expand Up @@ -199,7 +199,6 @@ AllowedAddressPairs:
- ip_address: 10.123.0.1
mac_address: 12:34:56:78:90:AB
- ip_address: 192.168.0.0/16
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -229,6 +228,7 @@ Tags:
- KopsInstanceGroup=node
- KopsName=port-node-1
- KubernetesCluster=cluster
WellKnownServices: null
---
ClusterName: cluster
ID: null
Expand Down
Expand Up @@ -25,7 +25,6 @@ Name: node-1-cluster
Port:
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -55,6 +54,7 @@ Port:
- KopsInstanceGroup=node
- KopsName=port-node-1
- KubernetesCluster=cluster
WellKnownServices: null
Region: region
Role: Node
SSHKey: kubernetes.cluster-ba_d8_85_a0_5b_50_b0_01_e0_b2_b0_ae_5d_f6_7a_d1
Expand Down Expand Up @@ -193,7 +193,6 @@ PublicACL: null
---
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -223,6 +222,7 @@ Tags:
- KopsInstanceGroup=node
- KopsName=port-node-1
- KubernetesCluster=cluster
WellKnownServices: null
---
ClusterName: cluster
ID: null
Expand Down
Expand Up @@ -87,7 +87,6 @@ Name: master-1-cluster
Port:
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: master
Lifecycle: Sync
Expand Down Expand Up @@ -123,6 +122,7 @@ Port:
- KopsInstanceGroup=master
- KopsName=port-master-1
- KubernetesCluster=cluster
WellKnownServices: null
Region: region
Role: ControlPlane
SSHKey: kubernetes.cluster-ba_d8_85_a0_5b_50_b0_01_e0_b2_b0_ae_5d_f6_7a_d1
Expand Down Expand Up @@ -178,7 +178,6 @@ Name: master-2-cluster
Port:
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: master
Lifecycle: Sync
Expand Down Expand Up @@ -214,6 +213,7 @@ Port:
- KopsInstanceGroup=master
- KopsName=port-master-2
- KubernetesCluster=cluster
WellKnownServices: null
Region: region
Role: ControlPlane
SSHKey: kubernetes.cluster-ba_d8_85_a0_5b_50_b0_01_e0_b2_b0_ae_5d_f6_7a_d1
Expand Down Expand Up @@ -269,7 +269,6 @@ Name: master-3-cluster
Port:
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: master
Lifecycle: Sync
Expand Down Expand Up @@ -305,6 +304,7 @@ Port:
- KopsInstanceGroup=master
- KopsName=port-master-3
- KubernetesCluster=cluster
WellKnownServices: null
Region: region
Role: ControlPlane
SSHKey: kubernetes.cluster-ba_d8_85_a0_5b_50_b0_01_e0_b2_b0_ae_5d_f6_7a_d1
Expand Down Expand Up @@ -355,7 +355,6 @@ Name: node-1-cluster
Port:
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -385,6 +384,7 @@ Port:
- KopsInstanceGroup=node
- KopsName=port-node-1
- KubernetesCluster=cluster
WellKnownServices: null
Region: region
Role: Node
SSHKey: kubernetes.cluster-ba_d8_85_a0_5b_50_b0_01_e0_b2_b0_ae_5d_f6_7a_d1
Expand Down Expand Up @@ -435,7 +435,6 @@ Name: node-2-cluster
Port:
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -465,6 +464,7 @@ Port:
- KopsInstanceGroup=node
- KopsName=port-node-2
- KubernetesCluster=cluster
WellKnownServices: null
Region: region
Role: Node
SSHKey: kubernetes.cluster-ba_d8_85_a0_5b_50_b0_01_e0_b2_b0_ae_5d_f6_7a_d1
Expand Down Expand Up @@ -515,7 +515,6 @@ Name: node-3-cluster
Port:
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -545,6 +544,7 @@ Port:
- KopsInstanceGroup=node
- KopsName=port-node-3
- KubernetesCluster=cluster
WellKnownServices: null
Region: region
Role: Node
SSHKey: kubernetes.cluster-ba_d8_85_a0_5b_50_b0_01_e0_b2_b0_ae_5d_f6_7a_d1
Expand Down Expand Up @@ -693,7 +693,6 @@ PublicACL: null
---
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: master
Lifecycle: Sync
Expand Down Expand Up @@ -729,10 +728,10 @@ Tags:
- KopsInstanceGroup=master
- KopsName=port-master-1
- KubernetesCluster=cluster
WellKnownServices: null
---
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: master
Lifecycle: Sync
Expand Down Expand Up @@ -768,10 +767,10 @@ Tags:
- KopsInstanceGroup=master
- KopsName=port-master-2
- KubernetesCluster=cluster
WellKnownServices: null
---
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: master
Lifecycle: Sync
Expand Down Expand Up @@ -807,10 +806,10 @@ Tags:
- KopsInstanceGroup=master
- KopsName=port-master-3
- KubernetesCluster=cluster
WellKnownServices: null
---
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -840,10 +839,10 @@ Tags:
- KopsInstanceGroup=node
- KopsName=port-node-1
- KubernetesCluster=cluster
WellKnownServices: null
---
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -873,10 +872,10 @@ Tags:
- KopsInstanceGroup=node
- KopsName=port-node-2
- KubernetesCluster=cluster
WellKnownServices: null
---
AdditionalSecurityGroups: null
AllowedAddressPairs: null
ForAPIServer: false
ID: null
InstanceGroupName: node
Lifecycle: Sync
Expand Down Expand Up @@ -906,6 +905,7 @@ Tags:
- KopsInstanceGroup=node
- KopsName=port-node-3
- KubernetesCluster=cluster
WellKnownServices: null
---
ClusterName: cluster
ID: null
Expand Down