Set the STS client's region via IMDS for AssumeRoleWithWebIdentity #16647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
hakman
approved these changes
Jul 3, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/milestone v1.31 |
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 17, 2024
…47-origin-release-1.30 Automated cherry pick of #16647: Set the STS client's region via IMDS for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #16645
The dns-controller pods can have AWS_WEB_IDENTITY_TOKEN_FILE set when OIDC is set up. This causes the route53 client constructor to initialize an sts client internally and call AssumeRoleWithWebIdentity. This STS client needs a region configured, so we attempt to discover one via IMDS.
If IMDS is disabled on the dns-controller pod's node, the cluster operator will need to set AWS_DEFAULT_REGION as a workaround.