service task: consider changes to the systemd manifest itself #2102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do smart service restarting: we restart the service if a dependency changed after the running service. However, we were not considering the service manifest itself in the calculation, which was an error. The bug only exposed itself though when we downloaded and updated docker, e.g. when running k8s 1.5 with a 1.4 image. We would write the env file early (no dependencies), then we would download docker and install it, and then we would write the service manifest. But if docker had been started during this interval (e.g. by protokube), then we would see that docker had been started after the dependencies (the env file), and not restart it. When we consider the manifest file also, things work as intended. Fix kubernetes#1731
k8s-ci-robot
added
the
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Waiting on CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do smart service restarting: we restart the service if a dependency
changed after the running service. However, we were not considering the
service manifest itself in the calculation, which was an error.
The bug only exposed itself though when we downloaded and updated
docker, e.g. when running k8s 1.5 with a 1.4 image. We would write the
env file early (no dependencies), then we would download docker and
install it, and then we would write the service manifest. But if docker
had been started during this interval (e.g. by protokube), then we would
see that docker had been started after the dependencies (the env file),
and not restart it. When we consider the manifest file also, things
work as intended.
Fix #1731
This change is