Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service task: consider changes to the systemd manifest itself #2102

Merged
merged 1 commit into from Mar 21, 2017

Commits on Mar 11, 2017

  1. service task: consider changes to the systemd manifest itself

    We do smart service restarting: we restart the service if a dependency
    changed after the running service.  However, we were not considering the
    service manifest itself in the calculation, which was an error.
    
    The bug only exposed itself though when we downloaded and updated
    docker, e.g. when running k8s 1.5 with a 1.4 image.  We would write the
    env file early (no dependencies), then we would download docker and
    install it, and then we would write the service manifest.  But if docker
    had been started during this interval (e.g. by protokube), then we would
    see that docker had been started after the dependencies (the env file),
    and not restart it.  When we consider the manifest file also, things
    work as intended.
    
    Fix kubernetes#1731
    justinsb committed Mar 11, 2017
    Configuration menu
    Copy the full SHA
    93ae440 View commit details
    Browse the repository at this point in the history