Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ingress-controller, default-backend and fixing permission for ClusterRole #2896

Merged
merged 6 commits into from
Jul 15, 2017

Conversation

BradErz
Copy link
Contributor

@BradErz BradErz commented Jul 10, 2017

Upgrading nginx-ingress-controller to 0.9.0-beta.10 and default backend server to 1.3.

Fixing the ClusterRole to allow permission to create/update config map as it complains.

Fixes: #2895

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @BradErz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chrislovecnm
Copy link
Contributor

/assign @aledbf

@chrislovecnm
Copy link
Contributor

@aledbf do you mind reviewing?

@chrislovecnm
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 10, 2017
@aledbf
Copy link
Member

aledbf commented Jul 10, 2017

@chrislovecnm sure

- ""
resources:
- endpoints
- configmaps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This permissions are too open. Please check https://github.com/kubernetes/ingress/tree/master/examples/rbac/nginx
We only need to update one configmap used to store the leader election.

@chrislovecnm
Copy link
Contributor

/retest

@BradErz
Copy link
Contributor Author

BradErz commented Jul 15, 2017

@aledbf Heya, sorry for getting back to you so late. Had a busy week!

I refactored it to match the nginx rbac recommendations, now it's using a role and cluster role. I tested on my test cluster and seems just fine.

@justinsb
Copy link
Member

Closing & reopening to trigger CI

@justinsb justinsb closed this Jul 15, 2017
@justinsb justinsb reopened this Jul 15, 2017
Copy link
Member

@justinsb justinsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinsb justinsb merged commit 97ce92d into kubernetes:master Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants