-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating ingress-controller, default-backend and fixing permission for ClusterRole #2896
Conversation
Hi @BradErz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @aledbf |
@aledbf do you mind reviewing? |
/ok-to-test |
@chrislovecnm sure |
addons/ingress-nginx/v1.6.0.yaml
Outdated
- "" | ||
resources: | ||
- endpoints | ||
- configmaps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This permissions are too open. Please check https://github.com/kubernetes/ingress/tree/master/examples/rbac/nginx
We only need to update one configmap used to store the leader election.
/retest |
…sed on the offical nginx docs
@aledbf Heya, sorry for getting back to you so late. Had a busy week! I refactored it to match the nginx rbac recommendations, now it's using a role and cluster role. I tested on my test cluster and seems just fine. |
Closing & reopening to trigger CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Upgrading nginx-ingress-controller to 0.9.0-beta.10 and default backend server to 1.3.
Fixing the ClusterRole to allow permission to create/update config map as it complains.
Fixes: #2895