Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly set lifecycle on LB resources #3226

Merged

Conversation

KashifSaadat
Copy link
Contributor

@KashifSaadat KashifSaadat commented Aug 17, 2017

When the cluster is configured with an ELB, the following resources show up on every update as requiring changes:

Will modify resources:
  DNSName/api.kash-kops.example.com
  	Lifecycle           	 <nil> -> Sync

    LoadBalancer/api.kash-kops.example.com
    	Lifecycle           	 <nil> -> Sync

    LoadBalancerAttachment/api-master-eu-west-1a
    	Lifecycle           	 <nil> -> Sync

    LoadBalancerAttachment/api-master-eu-west-1b
    	Lifecycle           	 <nil> -> Sync

    LoadBalancerAttachment/api-master-eu-west-1c
    	Lifecycle           	 <nil> -> Sync

This PR sets the lifecycle property on the above awstask objects.

@KashifSaadat
Copy link
Contributor Author

/assign @justinsb

@k8s-ci-robot
Copy link
Contributor

Hi @KashifSaadat. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 17, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 17, 2017
@justinsb
Copy link
Member

/ok-to-test

/lgtm

Good find, @KashifSaadat

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 17, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KashifSaadat, justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 189fa3c into kubernetes:master Aug 17, 2017
@KashifSaadat KashifSaadat deleted the fix-lifecycle-changes branch August 17, 2017 12:17
k8s-github-robot pushed a commit that referenced this pull request Aug 21, 2017
Automatic merge from submit-queue

Set lifecycle on ElasticIP and NAT Gateway tasks to avoid spurious changes

Identified in issue #476
Extension of fixes within PR #3226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants