Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kops 1.7 performs uneccesary rolling update even when no changes. #3450

Closed
prateeknayak opened this issue Sep 25, 2017 · 8 comments
Closed

Comments

@prateeknayak
Copy link

kops incorrectly thinks that the cluster needs to be updated every single time ever since we moved from kops 1.6 to kops 1.7 even though there is no change in the source code other than few .mds
0
In the plan stage it shows following

  DNSName/api.k8s.banana.com
  	Lifecycle           	 <nil> -> Sync

  InternetGateway/k8s.banana.com
  	Name                	 dev -> k8s.banana.com

  LaunchConfiguration/master-a.masters.k8s.banana.com
  	RootVolumeOptimization	 <nil> -> true

  LaunchConfiguration/master-b.masters.k8s.banana.com
  	RootVolumeOptimization	 <nil> -> true

  LaunchConfiguration/master-c.masters.k8s.banana.com
  	RootVolumeOptimization	 <nil> -> true

  LaunchConfiguration/master-d.masters.k8s.banana.com
  	RootVolumeOptimization	 <nil> -> true

  LaunchConfiguration/master-e.masters.k8s.banana.com
  	RootVolumeOptimization	 <nil> -> true

  LaunchConfiguration/nodes.k8s.banana.com
  	RootVolumeOptimization	 <nil> -> true

  LoadBalancer/api.k8s.banana.com
  	Lifecycle           	 <nil> -> Sync

  LoadBalancerAttachment/api-master-a
  	Lifecycle           	 <nil> -> Sync

  LoadBalancerAttachment/api-master-b
  	Lifecycle           	 <nil> -> Sync

  LoadBalancerAttachment/api-master-c
  	Lifecycle           	 <nil> -> Sync

  LoadBalancerAttachment/api-master-d
  	Lifecycle           	 <nil> -> Sync

  LoadBalancerAttachment/api-master-e
  	Lifecycle           	 <nil> -> Sync
......

What confuses me is

  • we aready have rootVolumeOptimization: true in kops cluster definition then why does it think that it needs to update ?
  • even if it wants to ignore the flag we have set, why would kops do it every single time ?

Please let us know if there is a fix for this or if it is feature ?

@gambol99
Copy link
Contributor

Hi @prateek-1708 ... I'm not sure about the LaunchConfiguration but the LoadBalancerAttachment was fixed on master #3226. .. I'll have a look a LaunchConfiguration

@prateeknayak
Copy link
Author

That would be super awesome ... thanks for the update @gambol99

@Pharb
Copy link
Contributor

Pharb commented Sep 27, 2017

@prateek-1708 the problem with the RootVolumeOptimization has been fixed on master, see #3313.

Until the next kops version is released, you can ignore the required changes from RootVolumeOptimization <nil> -> true by not starting the rolling update, or build your own kops version that includes the bugfix.

@chrislovecnm
Copy link
Contributor

@Pharb alpha is out as well, stability is not guaranteed as of yet, but they do not have to compile from source

@chrislovecnm
Copy link
Contributor

alpha kops version

@chrislovecnm
Copy link
Contributor

@prateek-1708 can we close this since this is fixed in master?

@prateeknayak
Copy link
Author

prateeknayak commented Sep 27, 2017

@chrislovecnm any idea if this would be patched to 1.7 release ?? or do we have to wait for 1.8 release ? and would that be 1.7 compatible ??

I will close the issue for now .... and if it happens again I will reopen. Thans @Pharb and @chrislovecnm for prompt response.

@chrislovecnm
Copy link
Contributor

@prateek-1708 1.8.0 alpha is out, and yes we are backward compatible with kubernetes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants