Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract UserData from CloudFormation output during testing #3299

Merged
merged 1 commit into from
Sep 6, 2017
Merged

Extract UserData from CloudFormation output during testing #3299

merged 1 commit into from
Sep 6, 2017

Conversation

justinsb
Copy link
Member

This gives us some sanity, so we can peek inside the base64 blob

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 28, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2017
@justinsb justinsb force-pushed the extract_userdata branch 2 times, most recently from 453bffd to f29d67a Compare August 28, 2017 16:06
KashifSaadat
KashifSaadat reviewed Aug 29, 2017
View reviewed changes
cmd/kops/integration_test.go Outdated
@@ -33,8 +33,13 @@ import (

"golang.org/x/crypto/ssh"

"encoding/base64"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to sort these, standard libraries at top and then alphabetical?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed them up a bit. Is there a tool you've found other than goimports? (goimports is good, but doesn't change the newline separated blocks)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! I'm using goimports too, so I just check manually when I remember to. :)

KashifSaadat
KashifSaadat approved these changes Aug 29, 2017
View reviewed changes
Copy link
Contributor

@KashifSaadat KashifSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, makes it a lot easier to spot issues and changes in the generated bootstrap scripts. 👍

Tested and works as expected.

@justinsb
Extract UserData from CloudFormation output during testing
e793562 
This gives us some sanity, so we can peek inside the base64 blob
@justinsb justinsb added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2017
@justinsb
Copy link
Member Author

Thanks @KashifSaadat !

@justinsb
Copy link
Member Author

/retest

1 similar comment
@justinsb
Copy link
Member Author

justinsb commented Sep 6, 2017

/retest

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 05cf84d into kubernetes:master Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KashifSaadat KashifSaadat KashifSaadat approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinsb @k8s-github-robot @KashifSaadat @k8s-ci-robot