-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Add-on] Add kube-state-metrics add-on #3653
[Add-on] Add kube-state-metrics add-on #3653
Conversation
Hi @tuannvm. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @zmerlynn |
I believe upup/pkg/fi/cloudup/bootstrapchannelbuilder.go needs to be updated to reference the manifest for deployment .. The PR looks fine a more general decision needs to be made by @chrislovecnm / @justinsb as to whether this should be part of kops ... I'm inclined to keep kops related to cluster build only and not support a collection a feature base addons |
thanks for the info @gambol99 |
I'm definitely happy to have it in Going to close & reopen to retrigger e2e. |
/lgtm Thanks @tuannvm ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Why?