Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add-on] Add kube-state-metrics add-on #3653

Conversation

tuannvm
Copy link
Contributor

@tuannvm tuannvm commented Oct 17, 2017

Why?

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @tuannvm. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 17, 2017
@tuannvm
Copy link
Contributor Author

tuannvm commented Oct 17, 2017

/assign @zmerlynn

@gambol99
Copy link
Contributor

I believe upup/pkg/fi/cloudup/bootstrapchannelbuilder.go needs to be updated to reference the manifest for deployment .. The PR looks fine a more general decision needs to be made by @chrislovecnm / @justinsb as to whether this should be part of kops ... I'm inclined to keep kops related to cluster build only and not support a collection a feature base addons

@tuannvm
Copy link
Contributor Author

tuannvm commented Oct 18, 2017

thanks for the info @gambol99

@justinsb
Copy link
Member

justinsb commented Nov 4, 2017

I'm definitely happy to have it in addons/; we can also promote it to an automatically installed part of kops separately/additionally.

Going to close & reopen to retrigger e2e.

@justinsb justinsb closed this Nov 4, 2017
@justinsb justinsb reopened this Nov 4, 2017
@justinsb
Copy link
Member

justinsb commented Nov 4, 2017

/lgtm

Thanks @tuannvm !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit b7611a3 into kubernetes:master Nov 4, 2017
@tuannvm tuannvm deleted the tuan-add-kube-state-metrics-addon branch November 7, 2017 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants