Add a v1.7.0 storage addon resource. #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/L
mikesplain
force-pushed
the
fix_storage_version
branch
3 times, most recently
from
d9f1a51
to
cacbcb3
Compare
|
/assign @chrislovecnm |
mikesplain
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
I may have found an issue, marking WIP |
mikesplain
force-pushed
the
fix_storage_version
branch
from
cacbcb3
to
e000d21
Compare
|
When testing this I ran into #3694, I don't think it's related. |
mikesplain
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
You tested with 1.6 and 1.7? |
|
K8s versions |
|
@chrislovecnm Yep. Tested on v1.6.8 and v1.7.8 |
chrislovecnm
approved these changes
Oct 24, 2017
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a stab at fixing this for both! Haven't tested it yet though.
Fixes #3298