Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tolerations in Canal spec so the pods can run on all nodes. #3802

Merged

Conversation

KashifSaadat
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 8, 2017
@KashifSaadat KashifSaadat changed the title Update tolerations so the pods can run on all nodes. Update tolerations in Canal spec so the pods can run on all nodes. Nov 8, 2017
@KashifSaadat
Copy link
Contributor Author

/assign @chrislovecnm @gambol99

Apologies I missed this out in my earlier PR :(

@gambol99
Copy link
Contributor

gambol99 commented Nov 8, 2017

LGTM

@KashifSaadat
Copy link
Contributor Author

/test pull-kops-e2e-kubernetes-aws

@chrislovecnm
Copy link
Contributor

chrislovecnm commented Nov 8, 2017

@KashifSaadat do the other providers have this as well?? Would need to be in another PR ...

@KashifSaadat
Copy link
Contributor Author

@chrislovecnm yeah, I brought this over from the working 1.6 policy (Calico v2.4.1).

@chrislovecnm
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2017
@chrislovecnm
Copy link
Contributor

/test pull-kops-e2e-kubernetes-aws

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants