Fix snake case #4520
Merged
Fix snake case #4520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Something odd happened with the commits here, but camelCase change looks good - thank you Let's rebase once 4381 merges :-) |
chrislovecnm
force-pushed
the
fix-snake-case
branch
from
99fb888
to
1ea0ca4
Compare
k8s-ci-robot
added
size/S
Follow-up PR to remove variables with snake case, and replace them with camel case.
chrislovecnm
force-pushed
the
fix-snake-case
branch
from
1ea0ca4
to
222dec0
Compare
|
/test pull-kops-e2e-kubernetes-aws |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrislovecnm, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #4381 and needs to be merged after that merges. This fixes a nit pit that I would in the PR review.