Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar mistakes #4687

Merged
merged 7 commits into from
Oct 8, 2018
Merged

Grammar mistakes #4687

merged 7 commits into from
Oct 8, 2018

Conversation

yjl-lgx
Copy link
Contributor

@yjl-lgx yjl-lgx commented Mar 16, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2018
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2018
@mikesplain
Copy link
Contributor

HI @yjl-lgx thanks for the cleanup, much appreciated!

Unfortunately, these files are actually autogenerated from code (e.g. https://github.com/kubernetes/kops/blob/master/cmd/kops/create.go#L71).

You'll need to:

  1. Setup a development environment
  2. Find those typos in the cli code, similar to the link above.
  3. Run make gen-cli-docs to generate the full docks properly.
  4. Check in the result as a single commit.

Please let me know if you have any questions! At that point you should see the tests start passing as well.

/ok-to-test
/assign

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 16, 2018
@mikesplain
Copy link
Contributor

@yjl-lgx any update on this? Let me know if you need any help!

@yjl-lgx
Copy link
Contributor Author

yjl-lgx commented Mar 23, 2018

/assign @andrewsykim

@andrewsykim
Copy link
Member

/assign @mikesplain

@mikesplain
Copy link
Contributor

@yjl-lgx it doesn't look like you've addressed my comments above: #4687 (comment)

Please let me know if you have any questions.

justinsb
justinsb reviewed Apr 2, 2018
View reviewed changes
docs/cli/kops_rolling-update.md Outdated
@@ -54,7 +54,7 @@ Note: terraform users will need to run all of the following commands from the sa

# Roll the k8s-cluster.example.com kops cluster,
# only roll the node instancegroup,
# use the new drain an validate functionality.
# use the new drain a validate functionality.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be "and" :-)

justinsb
justinsb reviewed Apr 2, 2018
View reviewed changes
docs/cli/kops_rolling-update_cluster.md Outdated
@@ -58,7 +58,7 @@ kops rolling-update cluster

# Roll the k8s-cluster.example.com kops cluster,
# only roll the node instancegroup,
# use the new drain an validate functionality.
# use the new drain a validate functionality.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be "and" :-)

@justinsb justinsb added this to the 1.10 milestone Apr 2, 2018
@justinsb justinsb modified the milestones: 1.10, 1.11 Jun 2, 2018
@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented Jun 5, 2018

@yjl-lgx any chance you could address the comments above? Would love to get this merged.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 3, 2018
@bheesham bheesham mentioned this pull request Sep 29, 2018
Merged
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 3, 2018
@k8s-ci-robot k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 3, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yjl-lgx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2018
@justinsb
Copy link
Member

justinsb commented Oct 8, 2018

Going to force-merge and throw into the docs-fix PR I have for the other ones where I did the same thing.

Thanks for the fix @yjl-lgx !

@justinsb justinsb merged commit 0bf814f into kubernetes:master Oct 8, 2018
justinsb added a commit to justinsb/kops that referenced this pull request Oct 9, 2018
@justinsb
Sync up CLI args help
01d188a 
Follow on to kubernetes#5425; another flag and we need to update the source code
as well as the output.

Follow on also to kubernetes#5721 and kubernetes#4687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

Assignees

@mikesplain mikesplain

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yjl-lgx @mikesplain @andrewsykim @rdrgmnzs @fejta-bot @k8s-ci-robot @justinsb