Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typo fix #5721

Merged
merged 8 commits into from
Oct 8, 2018
Merged

Small typo fix #5721

merged 8 commits into from
Oct 8, 2018

Conversation

AdamDang
Copy link
Contributor

Fix the typos :
"a ssh"->"an ssh"
"an new ssh"->"a new ssh"

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 30, 2018
@AdamDang
Copy link
Contributor Author

/assign @geojaz

@chrisz100
Copy link
Contributor

Just comment changes so no way affecting functionality.

Thanks @AdamDang !

/ok-to-test
/lgtm
/assign @mikesplain

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 1, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AdamDang, chrisz100
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geojaz

If they are not already assigned, you can assign the PR to them by writing /assign @geojaz in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrisz100
Copy link
Contributor

/area documentation

@chrisz100
Copy link
Contributor

@AdamDang before we merge this, can you please complete:

FAIL: make verify-gendocs failed, as the generated markdown docs are out of date.
FAIL: Please run the following command: make gen-cli-docs.

@bheesham
Copy link
Contributor

Looks like there's a lot of overlap with #4687. The only files not covered are:

  • docs/cli/kops_rolling-update.md; and
  • docs/cli/kops_rolling-update_cluster.md.

@justinsb
Copy link
Member

justinsb commented Oct 8, 2018

Going to force-merge and throw into the docs-fix PR I have for the other one where I did the same thing.

Thanks for the fix @AdamDang !

@justinsb justinsb closed this Oct 8, 2018
@justinsb justinsb reopened this Oct 8, 2018
@justinsb justinsb merged commit 4039ae8 into kubernetes:master Oct 8, 2018
justinsb added a commit to justinsb/kops that referenced this pull request Oct 9, 2018
Follow on to kubernetes#5425; another flag and we need to update the source code
as well as the output.

Follow on also to kubernetes#5721 and kubernetes#4687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants