Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cloudmock to pass govet #4949

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Fix cloudmock to pass govet #4949

merged 1 commit into from
Oct 9, 2018

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Apr 9, 2018

Builds on #4926

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 9, 2018
@justinsb justinsb added this to the 1.10 milestone Apr 9, 2018
@justinsb
Copy link
Member Author

justinsb commented Apr 9, 2018

So I'm guessing the behaviour changed in go 1.10, so we can't merge this until we're using go 1.10 (which I think is in k8s 1.10)

@chrislovecnm
Copy link
Contributor

So I'm guessing the behaviour changed in go 1.10, so we can't merge this until we're using go 1.10 (which I think is in k8s 1.10)

k8s 1.11 is go 1.10.1 if I am understanding your comment.

@justinsb justinsb modified the milestones: 1.10, 1.11 May 26, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2018
@justinsb
Copy link
Member Author

Blocked on #5817

@rdrgmnzs
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 23, 2018
@justinsb
Copy link
Member Author

/retest

Odd CI failure fetching kubelet hash; looking into adding a retry or a cache.

@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented Sep 24, 2018 •
edited
Loading

LGTM, from the previous comments it sounds like we can land this once #5823 lands.

@justinsb
Copy link
Member Author

justinsb commented Oct 8, 2018

Yes, should finally be good to go now :-)

@rdrgmnzs
Copy link
Contributor

rdrgmnzs commented Oct 9, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, rdrgmnzs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justinsb
Copy link
Member Author

justinsb commented Oct 9, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0c46432 into kubernetes:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rdrgmnzs rdrgmnzs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
1.11
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@justinsb @chrislovecnm @fejta-bot @rdrgmnzs @k8s-ci-robot