Update to k8s 1.11 libraries, fix code #5823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
|
Blocked on #5817 |
|
/retest |
k8s-ci-robot
added
the
needs-rebase
justinsb
force-pushed
the
deps_for_1_11
branch
from
d4d5948
to
bdf8cf8
Compare
k8s-ci-robot
removed
the
needs-rebase
justinsb
force-pushed
the
deps_for_1_11
branch
from
72d637d
to
5c9b9e4
Compare
justinsb
force-pushed
the
deps_for_1_11
branch
from
5c9b9e4
to
4e883ef
Compare
rdrgmnzs
reviewed
Sep 24, 2018
| @@ -17,15 +17,14 @@ limitations under the License. | |||
| package api | |||
|
|
|||
| import ( | |||
| v1 "k8s.io/api/core/v1" | |||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
| ) | |||
|
|
|||
| type Addons struct { | |||
| metav1.TypeMeta `json:",inline"` | |||
|
|
|||
| // We use v1.ObjectMeta so we don't serialize everything, even though we are using the full api machinery here (yet!) | |||
There was a problem hiding this comment.
Comment needs to be updated.
mikesplain
approved these changes
Sep 24, 2018
There was a problem hiding this comment.
Oh wow, didn't realize we hadn't done this yet. Thanks so much @justinsb! We should get this testing in the wild so I'm going to approve this now.
/lgtm
/approve
k8s-ci-robot
added
lgtm
k8s apimachinery is using strings.Builder, which was introduced in 1.10
justinsb
force-pushed
the
deps_for_1_11
branch
from
4e883ef
to
fac9071
Compare
k8s-ci-robot
removed
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain, rdrgmnzs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.